Skip to content

Remove all deprecated code #16338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 5, 2025
Merged

Remove all deprecated code #16338

merged 10 commits into from
Jan 5, 2025

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Release cycle things

Solution

Delete items deprecated in 0.15 and migrate bevy itself.

Testing

CI

@BenjaminBrienen BenjaminBrienen self-assigned this Nov 10, 2024
@BenjaminBrienen BenjaminBrienen added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Cross-Cutting Impacts the entire engine D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Help The author needs help finishing this PR. labels Nov 10, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Nov 10, 2024
@BenjaminBrienen BenjaminBrienen mentioned this pull request Nov 10, 2024
Closed
@BenjaminBrienen BenjaminBrienen added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Blocked This cannot move forward until something else changes and removed S-Needs-Help The author needs help finishing this PR. S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Nov 11, 2024
@BenjaminBrienen
Copy link
Contributor Author

Blocked on releasing 0.15

@BenjaminBrienen BenjaminBrienen changed the title Remove all deprecations Remove all deprecated code Nov 11, 2024
@BenjaminBrienen BenjaminBrienen mentioned this pull request Dec 17, 2024
Merged
@BenjaminBrienen BenjaminBrienen removed the S-Blocked This cannot move forward until something else changes label Jan 2, 2025
BD103
BD103 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!
image

@BenjaminBrienen BenjaminBrienen mentioned this pull request Jan 3, 2025
Merged
@BenjaminBrienen BenjaminBrienen requested a review from BD103 January 3, 2025 21:26
@LikeLakers2 LikeLakers2 mentioned this pull request Jan 3, 2025
Closed
2 tasks
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 4, 2025
@BenjaminBrienen BenjaminBrienen mentioned this pull request Jan 4, 2025
Merged
@LikeLakers2 LikeLakers2 mentioned this pull request Jan 5, 2025
Closed
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 5, 2025
Merged via the queue into bevyengine:main with commit 7112d55 Jan 5, 2025
28 checks passed
@BenjaminBrienen BenjaminBrienen deleted the remove-deprecations branch January 5, 2025 21:57
@LikeLakers2 LikeLakers2 mentioned this pull request Jan 6, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
@LikeLakers2
Remove bevy_core_pipeline::core_2d::Camera2dBundle (#17185)
51075aa 
# Objective
#16338 forgot to remove this
previously-deprecated item. In fact, it only removed the `#[deprecated]`
attribute attached to it.

## Solution
Removes `bevy_core_pipeline::core_2d::Camera2dBundle`.

## Testing
CI.
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@BenjaminBrienen @mrchantey
Remove all deprecated code (bevyengine#16338)
916c38e 
# Objective

Release cycle things

## Solution

Delete items deprecated in 0.15 and migrate bevy itself.

## Testing

CI
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@LikeLakers2 @mrchantey
Remove bevy_core_pipeline::core_2d::Camera2dBundle (bevyengine#17185)
b38510e 
# Objective
bevyengine#16338 forgot to remove this
previously-deprecated item. In fact, it only removed the `#[deprecated]`
attribute attached to it.

## Solution
Removes `bevy_core_pipeline::core_2d::Camera2dBundle`.

## Testing
CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LikeLakers2 LikeLakers2 LikeLakers2 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@lewiszlw lewiszlw lewiszlw approved these changes

@Jondolf Jondolf Awaiting requested review from Jondolf

@janhohenheim janhohenheim Awaiting requested review from janhohenheim

@BD103 BD103 Awaiting requested review from BD103

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Cross-Cutting Impacts the entire engine C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
5 participants
@BenjaminBrienen @LikeLakers2 @alice-i-cecile @lewiszlw @BD103