Fixed issue with derive_more Display Implementations
#16298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tuple structs and tuple enum variants, using `{0}` in a format-string doesn't refer to field zero, instead argument zero. This can go unnoticed if the format string already includes other (valid) fields.
Found all occurrences using re/#\[display\(.*\{[0-9]+\}.*\)\]/ and updated them to include an underscore, to refer to the field as intended.
This was discovered by @dtolnay.
bushrat011899
added
C-Bug
alice-i-cecile
approved these changes
Nov 8, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Nov 11, 2024
# Objective
- Fixed issue where `thiserror` `#[error(...)]` attributes were
improperly converted to `derive_more` `#[display(...)]` equivalents in
certain cases with a tuple struct/enum variant.
## Solution
- Used `re/#\[display\(.*\{[0-9]+\}.*\)\]/` to find occurences of using
`{0}` where `{_0}` was intended (checked for other field indexes too)and
updated accordingly.
## Testing
- `cargo check`
- CI
## Notes
This was discovered by @dtolnay in [this
comment](#15772 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
thiserror#[error(...)]attributes were improperly converted toderive_more#[display(...)]equivalents in certain cases with a tuple struct/enum variant.Solution
re/#\[display\(.*\{[0-9]+\}.*\)\]/to find occurences of using{0}where{_0}was intended (checked for other field indexes too)and updated accordingly.Testing
cargo checkNotes
This was discovered by @dtolnay in this comment.