-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos, grammar, and spelling mistakes #16273
base: main
Are you sure you want to change the base?
Conversation
The generated |
Mostly like these changes, but they should probably be held back until after the 0.15 release cycle is complete to avoid cherry-picking conflicts. I am curious as to why Quite a few breaking changes. One is a super obvious typo that should definitely get fixed up. No opinion on others. |
@rparrett I think I addressed all the feedback. Most of it was adding to the migration guide and applying your suggestions. Let me know if you have further comments! :) |
I have submitted the basic English typos to the typos CI repository. I can add the long list of exceptions to the |
Objective
Code and documentation should use words that exist and are spelled correctly.
Also, I noticed a markdownlint warning to do with the table at the bottom having left and right bars (inconsistent style) so I fixed the template file.
Solution
I used the cSpell VS Code extension and literally opened every single
.rs
file to see if it popped up anycSpell
"Problems". Most of them were added as "words" insettings.json
. See here:Testing
The CI should be good.
Migration Guide
Color::rbga_linear
->Color::rgba_linear
CubicSegment.coeff
->CubicSegment.coefficients
RationalSegment.coeff
->RationalSegment.coefficients
RationalSegment.weight_coeff
->RationalSegment.weight_coefficients
Curve::reparameterize
->Curve::reparametrize
Curve::reparametrize_linear
->Curve::reparameterize_linear
Curve::reparametrize_by_curve
->Curve::reparameterize_by_curve
FallbackImageMsaa::image_for_samplecount
->FallbackImageMsaa::image_for_sample_count
prepare_uimaterial_nodes
->prepare_ui_material_nodes
GridTrack::vmin
->GridTrack::v_min
GridTrack::vmax
->GridTrack::v_max
ExitCondition::DontExit
->ExitCondition::DoNotExit
WinitWindows::get_fitting_videomode
->WinitWindows::get_fitting_video_mode
get_best_videomode
->get_best_video_mode
RepeatedGridTrack::vmin
->RepeatedGridTrack::v_min
RepeatedGridTrack::vmax
->RepeatedGridTrack::v_max