Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - format comments #1612

Closed
wants to merge 1 commit into from
Closed

Conversation

cart
Copy link
Member

@cart cart commented Mar 10, 2021

Uses the new unstable comment formatting features added to rustfmt.toml.

@cart cart added the C-Code-Quality A section of code that is hard to understand or change label Mar 10, 2021
@cart
Copy link
Member Author

cart commented Mar 10, 2021

Hmm something to be mindful of:

This will mess up # Safety sections if they aren't preceded by a newline

image

@cart
Copy link
Member Author

cart commented Mar 10, 2021

Fortunately clippy will yell at us if this happens, but we won't get yelled at for non-safety headers, so newlines are something we'll want to enforce if we plan on using these settings.

@cart
Copy link
Member Author

cart commented Mar 11, 2021

bors r+

bors bot pushed a commit that referenced this pull request Mar 11, 2021
Uses the new unstable comment formatting features added to rustfmt.toml.
@bors bors bot changed the title format comments [Merged by Bors] - format comments Mar 11, 2021
@bors bors bot closed this Mar 11, 2021
bors bot pushed a commit that referenced this pull request Mar 13, 2021
Fixes all warnings from `cargo doc --all`.
Those related to code blocks were introduced in #1612, but re-formatting using the experimental features in `rustfmt.toml` doesn't seem to reintroduce them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant