Refactor TextPipeline::update_buffer to accept an interator #15581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
UkoeHB
removed
the
S-Waiting-on-Author
kristoff3r
approved these changes
Oct 1, 2024
Contributor
kristoff3r
left a comment
kristoff3r
left a comment
There was a problem hiding this comment.
Not super familiar with this code but the changes make sense to me. I tested the text example and it still works.
alice-i-cecile
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Oct 1, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Member
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
…ne#15581) # Objective - Prepare `TextPipeline` to work with multi-entity text blocks. See bevyengine#15014 ## Solution - Refactor `TextPipeline::update_buffer` to accept an iterator instead of slice. Adjust `update_buffer` implementation to only iterate spans once instead of three times (which would require iterating a hierarchy three times with multi-entity blocks). ## Testing - Tested with `text_debug` example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TextPipelineto work with multi-entity text blocks. See Bevy Text rework: TextBlock #15014Solution
TextPipeline::update_bufferto accept an iterator instead of slice. Adjustupdate_bufferimplementation to only iterate spans once instead of three times (which would require iterating a hierarchy three times with multi-entity blocks).Testing
text_debugexample.