Skip to content

rename QuerySingle to Single #15507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Sep 29, 2024
Merged

rename QuerySingle to Single #15507

alice-i-cecile merged 1 commit into from
Sep 29, 2024

Conversation

@hooded-shrimp
Copy link
Contributor

@hooded-shrimp hooded-shrimp commented Sep 28, 2024

bas-ie
bas-ie approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@bas-ie bas-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bas-ie bas-ie added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Sep 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 29, 2024
Merged via the queue into bevyengine:main with commit 8316d89 Sep 29, 2024
@hooded-shrimp hooded-shrimp deleted the rename-query-single branch October 1, 2024 17:42
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
@hooded-shrimp @robtfm
rename QuerySingle to Single (bevyengine#15507)
75bcf46 
# Objective

- Fixes bevyengine#15504
mgi388 added a commit to mgi388/bevy that referenced this pull request Oct 5, 2024
@mgi388
Fix QuerySingle -> Single missed in example
f7068c6 
Missed in bevyengine#15507
@mgi388 mgi388 mentioned this pull request Oct 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 5, 2024
@mgi388
Fix QuerySingle -> Single missed in example (#15667)
7c03ca2 
Missed in #15507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@bas-ie bas-ie bas-ie approved these changes

@atornity atornity atornity approved these changes

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename new QuerySingle param to Single

5 participants

@hooded-shrimp @bas-ie @atornity @BenjaminBrienen @alice-i-cecile