Add with_child
to simplify spawning when there will only be one child
#14594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This idea came up in the context of a hypothetical "text sections as entities" where text sections are children of a text bundle.
This is a bit cumbersome (but powerful and probably the way things are headed).
bsn!
will eventually make this nicer, but in the mean time, this might improve ergonomics for the common case where there is only oneTextSection
.Solution
Add a
with_child
method to theBuildChildren
trait that spawns a single bundle and adds it as a child to the entity.Testing
I added some tests, and modified the
button
example to use the new method.If any potential co-authors want to improve the tests, that would be great.
Alternatives
bsn!
.bsn!
with_children_batch
that takes anInto<Iterator>
of bundles.