Fix bevy_render's image dependency version
#14505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Jul 28, 2024
alice-i-cecile
added
A-Rendering
Member
|
Good explanation, thank you :) |
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
# Objective - `bevy_render` depends on `image 0.25` but uses `image::ImageReader` which was added only in `image 0.25.2` - users that have `image 0.25` in their `Cargo.lock` and update to the latest `bevy_render` may thus get a compilation due to this (at least I did) ## Solution - Properly set the correct minimum version of `image` that `bevy_render` depends on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_renderdepends onimage 0.25but usesimage::ImageReaderwhich was added only inimage 0.25.2image 0.25in theirCargo.lockand update to the latestbevy_rendermay thus get a compilation due to this (at least I did)Solution
imagethatbevy_renderdepends on.