Make the component types of the new animation players clonable. #13736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mintlu8
changed the title
mintlu8
changed the title
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Jun 7, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
mockersf
pushed a commit
that referenced
this pull request
Jun 7, 2024
# Objective Some use cases might require holding onto the previous state of the animation player for change detection. ## Solution Added `clone` and `copy` implementation to most animation types. Added optimized `clone_from` implementations for the specific use case of holding a `PreviousAnimationPlayer` component. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
mockersf
pushed a commit
that referenced
this pull request
Jun 8, 2024
# Objective Some use cases might require holding onto the previous state of the animation player for change detection. ## Solution Added `clone` and `copy` implementation to most animation types. Added optimized `clone_from` implementations for the specific use case of holding a `PreviousAnimationPlayer` component. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Some use cases might require holding onto the previous state of the animation player for change detection.
Solution
Added
cloneandcopyimplementation to most animation types.Added optimized
clone_fromimplementations for the specific use case of holding aPreviousAnimationPlayercomponent.