-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates default Text font size to 24px #13603
Updates default Text font size to 24px #13603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer for the examples! I've updated the PR description a bit to make it clearer and improve the migration guide.
5c45cf4
to
24d8a70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a lovely diff.
(Non-blocking) There may be a few examples where FiraMono-Medium
is manually specified and doesn't need to be.
There are a few that do need it because the help text uses glyphs beyond the limited set the default font contains. But I think a few may not.
In one case, I was able to use the default after swapping out unicode em-dashes for regular dashes. But some examples need "box drawing" glyphs.
I could split this up into several PRs but figured out that it was going to be too much work and then we'd be testing every single example on a different PR (or something like that). ETOOMANYEXAMPLES 😅 I'll check those examples you mentioned and reduce code a bit more where possible, I like the idea. |
Ping me when you're done cleaning up and I'll validate it quick before merging :) |
@alice-i-cecile finished with getting rid of the default font loading where appropriate. I did some extra cleanup in places where the default text color was used too. |
Objective
Solution
TextStyle
from 12px to 24px.Testing
Migration Guide
Default
text style.