Make SystemParam::new_archetype and QueryState::new_archetype unsafe functions

[james7132]

Objective

Fix #2128. Both Query::new_archetype and SystemParam::new_archetype do not check if the Archetype comes from the same World the state is initialized from. This could result in unsoundness via invalid accesses if called incorrectly.

Solution

Make them unsafe functions and lift the invariant to the caller. This also caught one instance of us not validating the World in SystemState::update_archetypes_unsafe_world_cell's implementation.

---

Changelog

Changed: QueryState::new_archetype is now an unsafe function.
Changed: SystemParam::new_archetype is now an unsafe function.

Migration Guide

QueryState::new_archetype and SystemParam::new_archetype are now an unsafe functions that must be sure that the provided Archetype is from the same World that the state was initialized from. Callers may need to add additional assertions or propagate the safety invariant upwards through the callstack to ensure safety.