Cleanup the multithreaded executor #12969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Improve the code quality of the multithreaded executor.
Solution
Mutex::get_mut
where applicable instead of locking.startup_systems
FixedBitset to pre-compute the starting systems instead of building it bit-by-bit on startup.FixedBitset::clear
andFixedBitset::union_with
, useFixedBitset::clone_from
instead, which does only a single copy and will not allocate if the target bitset has a large enough allocation.Mutex
aroundConditions
withSyncUnsafeCell
, and add aContext::try_lock
that forces it to be synchronized fetched alongside the executor lock.This might produce minimal performance gains, but the focus here is on the code quality improvements.