Update tracing-tracy requirement from 0.10.4 to 0.11.0 and tracy-client requirement from 0.16.4 to 0.17.0 #11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [tracing-tracy](https://github.com/nagisa/rust_tracy_client) to permit the latest version. - [Commits](nagisa/rust_tracy_client@tracing-tracy-v0.10.4...tracing-tracy-v0.11.0) --- updated-dependencies: - dependency-name: tracing-tracy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Kanabenki
force-pushed
the
tracing-tracy-0.11.0-tracy-client-0.17.0
branch
from
db34920 to
9093a5e
Compare
mockersf
approved these changes
Feb 3, 2024
alice-i-cecile
approved these changes
Feb 3, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Thanks for tackling this :) |
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
…ent requirement from 0.16.4 to 0.17.0 (bevyengine#11678) # Objective - Update `tracing-tracy`. - Closes bevyengine#11598. ## Solution - Bump `tracing-tracy` to 0.11.0 and `tracy-client` alongside it to 0.17.0 to avoid duplicating that dependency in the deps tree. - `TracyLayer` is now configurable on creation, so use the default config. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
This PR broke stable Tracy, requiring all users to now compile Tracy from source where they didn't need to before. Do we really want to do that? |
|
I just tested with Tracy 0.10 and it seems to be working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
tracing-tracy.Solution
tracing-tracyto 0.11.0 andtracy-clientalongside it to 0.17.0 to avoid duplicating that dependency in the deps tree.TracyLayeris now configurable on creation, so use the default config.