Add custom schedule example #11527
Merged
Add custom schedule example #11527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generated |
|
I think the comment above is inaccurate. I fixed the issue in 218e570, before CI failed. Running the command again results in an empty changeset. |
doonv
approved these changes
Jan 25, 2024
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Jan 25, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
# Objective While working on #11527 I spotted that the internal field for the label of a `Schedule` is called `name`. Using `label` seems more in line with the other naming across Bevy. ## Solution Renaming the field was straightforward since it's not exposed outside of the module. This also means a changelog or migration guide isn't necessary.
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective Fixes bevyengine#11411 ## Solution - Added a simple example how to create and configure custom schedules that are run by the `Main` schedule. - Spot checked some of the API docs used, fixed `App::add_schedule` docs that referred to a function argument that was removed by bevyengine#9600. ## Open Questions - While spot checking the docs, I noticed that the `Schedule` label is stored in a field called `name` instead of `label`. This seems unintuitive since the term label is used everywhere else. Should we change that field name? It was introduced in bevyengine#9600. If so, I do think this change would be out of scope for this PR that mainly adds the example.
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective While working on bevyengine#11527 I spotted that the internal field for the label of a `Schedule` is called `name`. Using `label` seems more in line with the other naming across Bevy. ## Solution Renaming the field was straightforward since it's not exposed outside of the module. This also means a changelog or migration guide isn't necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #11411
Solution
Mainschedule.App::add_scheduledocs that referred to a function argument that was removed by Move schedule name intoSchedule#9600.Open Questions
Schedulelabel is stored in a field callednameinstead oflabel. This seems unintuitive since the term label is used everywhere else. Should we change that field name? It was introduced in Move schedule name intoSchedule#9600. If so, I do think this change would be out of scope for this PR that mainly adds the example.