Skip to content

Loading non-color maps as sRGB in StandardMaterial silently looks wrong #19089

Open
@Noxmore

Description

@Noxmore

What problem does this solve or what need does it fill?

With StandardMaterial, as far as i know any non-color maps are supported to be linear. When creating one with sRGB images (the default) it looks quite incorrect without telling the user why.

What solution would you like?

Log a warning if sRGB maps are used where they shouldn't be. This would've saved me a lot of time tracking this down. (I only ended up discovering why because of the help of @janhohenheim, thanks!)

Considering that glTFs automatically load the relevant maps as linear, what i would really like is if this was done automatically when creating a StandardMaterial, but as far as i know we have no way of know which map a loaded image will be used for, so i think that's off the table.

Additional Context

I was unsure whether to label this a bug or a feature request, i don't mind it being changed if it would be better considered a bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-RenderingDrawing game state to the screenA-glTFRelated to the glTF 3D scene/model formatC-UsabilityA targeted quality-of-life change that makes Bevy easier to useD-ModestA "normal" level of difficulty; suitable for simple features or challenging fixesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed upon

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions