rust-analyzer autocomplete is broken for some ECS types

[C-Entropy]

Bevy version

git bisect lead to 760d0a3

• the Rust version you're using (you can get this by running cargo --version)
  cargo --version
  cargo 1.83.0 (5ffbef321 2024-10-29)

What went wrong

As you can see, I can't get game. complete its fields, while there are other options.

[BenjaminBrienen]

I can reproduce this. It should show the player field. (there is no scroll here)

[alice-i-cecile]

That's a very odd place for the bisection to lead us 🤔 Are we sure this wasn't caused by a change in RA instead?

[C-Entropy]

What is RA？
If you mean rust-analyzer, I have tried the version from Aug. to the least release, however, the issue remains.

[alice-i-cecile]

Yeah, rust-analyzer. Hmm, that's very unusual. Can you double check the bisection? Maybe a PR just before or after is causing the problem. Or try reverting that commit.

[C-Entropy]

I have already tried the commit just before, which works fine. I will check it again when I'm free

[C-Entropy]

I have tried

1. 73a66d6

git check out 73a66d6bd8e3d21b928f2a31f1aff5c9fb95a564

2. 760d0a3

git checkout main
git revert 760d0a3

both works fine with

rust-analyzer --version
rust-analyzer 1.83.0 (90b35a6 2024-11-26)

[mdickopp]

I tracked this down to bevy_ecs_path.

  pub(crate) fn bevy_ecs_path() -> syn::Path {
-     BevyManifest::default().get_path("bevy_ecs")
+     BevyManifest::shared().get_path("bevy_ecs")
  }

The difference seems to be that before 760d0a3, this function returned bevy_internal::ecs, and now it returns bevy_ecs.