Skip to content

Update .gitignore and templates to resize donor and news images #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MyZeD
Copy link
Contributor

@MyZeD MyZeD commented Oct 8, 2024

Optimize the size of the donor logos as they are too large. (See first screenshot)

The total file size of all images is 2.3 MB - in the new version the resizing only occurs in the rendered view to the same maximum height.
The result: 704kB (see 2. screenshot).

Bildschirmfoto vom 2024-10-08 18-33-54
Bildschirmfoto vom 2024-10-08 18-34-25

I also adjusted the height and width of the news images to the maximum rendering size.

I also wrote the donor_logos in the gitignore so that you can't upload them accidentally.

@alice-i-cecile alice-i-cecile added C-Webdev A-Foundation Donations, minutes and other bureaucracy S-Needs-Review labels Oct 11, 2024
Copy link
Contributor

@krunchington krunchington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of the resize_image macro, and clamping to integers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Foundation Donations, minutes and other bureaucracy C-Webdev S-Needs-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants