Skip to content

Commit 33e645e

Browse files
louyutingsczyh30
authored andcommitted
Enhance hotspot.Rule checking logic
1 parent babb122 commit 33e645e

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

core/hotspot/rule_manager.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ func IsValidRule(rule *Rule) error {
277277
if rule.ParamIndex < 0 {
278278
return errors.New("invalid param index")
279279
}
280-
if rule.DurationInSec < 0 {
280+
if rule.MetricType == QPS && rule.DurationInSec <= 0 {
281281
return errors.New("invalid duration")
282282
}
283283
return checkControlBehaviorField(rule)

core/hotspot/traffic_shaping.go

+2
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ func newBaseTrafficShapingController(r *Rule) *baseTrafficShapingController {
5353
size := 0
5454
if r.ParamsMaxCapacity > 0 {
5555
size = int(r.ParamsMaxCapacity)
56+
} else if r.DurationInSec == 0 {
57+
size = ParamsMaxCapacity
5658
} else {
5759
size = int(math.Min(float64(ParamsMaxCapacity), float64(ParamsCapacityBase*r.DurationInSec)))
5860
}

0 commit comments

Comments
 (0)