Skip to content

Add new target EMAX_F722 #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

EmaxModel
Copy link
Contributor

@EmaxModel EmaxModel commented Feb 26, 2025

add new target EMAX_F722

Summary by CodeRabbit

  • New Features
    • Added support for the EMAX F722 flight controller board, including configuration for sensors, peripherals, and hardware pin assignments.
    • Enabled features such as gyro, accelerometer, barometer, flash memory, on-screen display, and blackbox logging for this board.

@EmaxModel
Copy link
Contributor Author

mcu

@ot0tot
Copy link
Contributor

ot0tot commented Feb 26, 2025

Please review the manufacturer design guidelines: https://betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines and submit the schematic for review on the Discord.

Note that per the announcement made on 12/3/24, F7 FCs now support a maximum of 4 motor outputs.

@EmaxModel
Copy link
Contributor Author

Whether the led pin can be approved after the change

@ot0tot
Copy link
Contributor

ot0tot commented Mar 19, 2025

Whether the led pin can be approved after the change

Yes, should be ok. Have you made the other changes requested on the Discord?

@EmaxModel
Copy link
Contributor Author

Whether the led pin can be approved after the change

Yes, should be ok. Have you made the other changes requested on the Discord?

Yes, we have made changes

Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
@EmaxModel
Copy link
Contributor Author

Whether the led pin can be approved after the change

Yes, should be ok. Have you made the other changes requested on the Discord?

What other information do we need to provide to pass f722

@ot0tot
Copy link
Contributor

ot0tot commented Mar 25, 2025

Can you post the updated schematic in the Discord?

@EmaxModel
Copy link
Contributor Author

Can you post the updated schematic in the Discord?

sure

@ot0tot
Copy link
Contributor

ot0tot commented Mar 25, 2025

Updated schematic does not follow the manufacturer design guidelines or the connector standard. Feedback provided in the Discord.

Copy link

coderabbitai bot commented Jun 23, 2025

Walkthrough

A new configuration header file for the EMAX F722 flight controller board has been introduced. This file defines the MCU type, board identifiers, enables specific sensors and peripherals, assigns GPIO pins, sets up timer mappings, and specifies default hardware instances and settings for various onboard components.

Changes

File(s) Change Summary
configs/EMAX_F722/config.h Added new board configuration header with MCU, sensor, peripheral, pin, timer, and hardware settings.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Firmware
    participant EMAX_F722 Board

    User->>Firmware: Build for EMAX_F722 target
    Firmware->>EMAX_F722 Board: Apply config.h settings
    EMAX_F722 Board-->>Firmware: Board initialized with defined sensors, peripherals, and pin mappings
Loading

Possibly related PRs

  • Add AXISFLYINGF745AIO config #581: Both PRs add new configuration header files for different flight controller boards, defining MCU targets, sensor setups, pin assignments, and default hardware settings.
  • Add AIKONF4V3 #715: Both PRs add new configuration header files for different flight controller boards, defining similar sets of macros for MCU, sensors, peripherals, pin assignments, and default hardware settings.
  • Add New Target DAKEFPVH743Pro #793: Adds a new board configuration header file for another flight controller, similar in purpose and structure.

Suggested reviewers

  • ot0tot
  • haslinghuis

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae5ae79 and 7efde81.

📒 Files selected for processing (1)
  • configs/EMAX_F722/config.h (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • configs/EMAX_F722/config.h
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants