display new multi dynamic notch values properly in log header for 4.3 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shows a 4.3 log with one notch and bandwidth 30 |
|
SonarCloud Quality Gate failed.
|
|
Closing since superseded now by #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic notch has changed recently. This PR idisplays the new values in the gyro filters section of the log.
I thought it might be worth exploring using the same html fields for the old values that are replaced, since they are, sort of, comparable.
The old dynamic notch width parameter determined whether there was one or two notches while the new count parameter sets the actual number of notches. Likewise the old Q factor determined notch bandwidth, and the new bandwidth parameter sets it directly.
Hence I am using the one html field for count / width, and the other for bandwidth / Q, depending on the version of the flight code.
The alternative is to force zeroes for count and bandwidth for <4.3, and put the older fields into the unrecognised headers.
I appreciate feedback on this.