update feedforward log headers for 4.3 #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shows the log header with 4.3 feed forward values: |
|
Superseded by #512 |
|
not sure why it got closed |
|
whoops |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This correctly displays the new feedforward fields and name changes that will end up in 4.3 from #01723
Previously only feedforward transition was shown; the extra feedforward sub parameters were shown only in the Unknown Headers section.
This shows all 4.3 feedforward parameters in a box.
The only common feed forward fields from 4.2 to 4.3 are transition and boost. When showing a 4.2 and earlier log, the new fields for averaging, smoothing and jitter are set to 0, and the older parameter names and values are shown in the Unknown Header Fields section.