Skip to content

Commit 7ba9854

Browse files
committed
improve feedforward debug modes
1 parent 6e62129 commit 7ba9854

File tree

3 files changed

+43
-12
lines changed

3 files changed

+43
-12
lines changed

js/flightlog_fielddefs.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,8 @@ var
322322
"BARO",
323323
"GPS_RESCUE_THROTTLE_PID",
324324
"DYN_IDLE",
325-
"FEEDFORWARD_LIMIT",
326-
"FEEDFORWARD",
325+
"FF_LIMIT",
326+
"FF_INTERPOLATED",
327327
]),
328328

329329
SUPER_EXPO_YAW = makeReadOnly([
@@ -480,6 +480,10 @@ function adjustFieldDefsList(firmwareType, firmwareVersion) {
480480
DEBUG_MODE.splice(DEBUG_MODE.indexOf('DUAL_GYRO'), 1);
481481
DEBUG_MODE.splice(DEBUG_MODE.indexOf('DUAL_GYRO_COMBINED'), 1);
482482
}
483+
if(semver.gte(firmwareVersion, '4.3.0')) {
484+
DEBUG_MODE.splice(DEBUG_MODE.indexOf('FF_INTERPOLATED'), 1, 'FEEDFORWARD');
485+
DEBUG_MODE.splice(DEBUG_MODE.indexOf('FF_LIMIT'), 1, 'FEEDFORWARD_LIMIT');
486+
}
483487
DEBUG_MODE = makeReadOnly(DEBUG_MODE);
484488

485489
// Flight mode names

js/flightlog_fields_presenter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,14 +442,14 @@ function FlightLogFieldPresenter() {
442442
};
443443
}
444444
if (semver.gte(firmwareVersion, '4.3.0')) {
445-
DEBUG_FRIENDLY_FIELD_NAMES.FF_INTERPOLATED = {
445+
DEBUG_FRIENDLY_FIELD_NAMES.FEEDFORWARD = {
446446
'debug[all]':'Feedforward [roll]',
447447
'debug[0]':'Setpoint, interpolated [roll]',
448448
'debug[1]':'Delta, smoothed [roll]',
449449
'debug[2]':'Boost, smoothed [roll]',
450450
'debug[3]':'rcCommand Delta [roll]',
451451
};
452-
DEBUG_FRIENDLY_FIELD_NAMES.FF_LIMIT = {
452+
DEBUG_FRIENDLY_FIELD_NAMES.FEEDFORWARD_LIMIT = {
453453
'debug[all]':'Feedforward Limit [roll]',
454454
'debug[0]':'Feedforward input [roll]',
455455
'debug[1]':'Feedforward input [pitch]',

js/graph_config.js

Lines changed: 35 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -535,14 +535,27 @@ GraphConfig.load = function(config) {
535535
return getCurveForMinMaxFieldsZeroOffset(fieldName);
536536
}
537537
break;
538-
case 'FEEDFORWARD_LIMIT':
539-
return {
540-
offset: 0,
541-
power: 1.0,
542-
inputRange: 300,
543-
outputRange: 1.0
544-
};
545-
case 'FEEDFORWARD':
538+
case 'FF_INTERPOLATED':
539+
switch (fieldName) {
540+
case 'debug[0]': // setpoint Delta
541+
case 'debug[1]': // AccelerationModified
542+
case 'debug[2]': // Acceleration
543+
return {
544+
offset: 0,
545+
power: 1.0,
546+
inputRange: 1000,
547+
outputRange: 1.0
548+
};
549+
case 'debug[3]': // Clip or Count
550+
return {
551+
offset: -10,
552+
power: 1.0,
553+
inputRange: 10,
554+
outputRange: 1.0
555+
};
556+
}
557+
break;
558+
case 'FEEDFORWARD': // replaces FF_INTERPOLATED in 4.3
546559
switch (fieldName) {
547560
case 'debug[0]': // in 4.3 is interpolated setpoint
548561
return {
@@ -568,6 +581,20 @@ GraphConfig.load = function(config) {
568581
};
569582
}
570583
break;
584+
case 'FF_LIMIT':
585+
return {
586+
offset: 0,
587+
power: 1.0,
588+
inputRange: 300,
589+
outputRange: 1.0
590+
};
591+
case 'FEEDFORWARD_LIMIT':
592+
return {
593+
offset: 0,
594+
power: 1.0,
595+
inputRange: 300,
596+
outputRange: 1.0
597+
};
571598
}
572599
}
573600
// if not found above then

0 commit comments

Comments
 (0)