Skip to content

Trim acc #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
druckgott wants to merge 9 commits into from
Closed

Trim acc #457

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21ead4f
Add Page: Trim Accelerometer
druckgott Nov 12, 2022
e808f95
Add Page to Trim Accelerometer
druckgott Nov 12, 2022
1535b18
Update name: acc_trim.lua
druckgott Nov 12, 2022
a8d0765
Fix Points in File
druckgott Nov 12, 2022
3383fd7
Delete acc_calibrate.lua
druckgott Nov 12, 2022
b19b6a6
Update acc_trim.lua
druckgott Nov 13, 2022
1a9b57f
Fix problem with negativ values
druckgott Nov 13, 2022
d131e74
size down calculation
druckgott Nov 13, 2022
d25763d
remove postload due to generic way
druckgott Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/SCRIPTS/BF/PAGES/acc_calibrate.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@

Copy link
Member

@klutvott123 klutvott123 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want this

local template = assert(loadScript(radio.template))()
local margin = template.margin
local indent = template.indent
local lineSpacing = template.lineSpacing
local tableSpacing = template.tableSpacing
local sp = template.listSpacing.field
local yMinLim = radio.yMinLimit
local x = margin
local y = yMinLim - lineSpacing
local inc = { x = function(val) x = x + val return x end, y = function(val) y = y + val return y end }
local labels = {}
local fields = {}

if apiVersion >= 1.041 then
Copy link
Member

@klutvott123 klutvott123 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values have been available through msp in betaflight since msp api version 1.16(we had msp over telemetry since then) so this conditional is not needed.

We only need conditionals like this in the page file itself if parameters are removed/added to the message along the way.
In this case the only conditional needed is the one in "pages.lua" that makes the whole page conditional to msp api version 1.16

What would happen here is that for api versions lower than 1.41 the page would still be accessible, but would be empty.

Copy link
Member

@haslinghuis haslinghuis Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if apiVersion >= 1.041 then
if apiVersion >= 1.16 then

labels[#labels + 1] = { t = "Trim Accelerometer" , x = x, y = inc.y(lineSpacing) }
fields[#fields + 1] = { t = "acc trim pitch", x = x, y = inc.y(lineSpacing), sp = x + sp, min = -300, max = 300, vals = { 1 } }
fields[#fields + 1] = { t = "acc trim roll", x = x, y = inc.y(lineSpacing), sp = x + sp, min = -300, max = 300, vals = { 2 } }
Copy link
Member

@klutvott123 klutvott123 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much indent.
The field text could also be just "Pitch" and "Roll" since the "Trim Accelerometer" header explains it all. These should also be indented. "x = x + indent" for both of these. Look at the other pages to see how we usually do it.

This won't work as it should. both pitch and roll trim are 16 bit values so for pitch it should be "vals = { 1, 2 }" and for roll "vals = { 3, 4 }". Have a look at the MSP_ACC_TRIM" message in the BF source code. 🙂

end

return {
read = 240, -- MSP_ACC_TRIM
write = 239, -- MSP_SET_ACC_TRIM
title = "ACC",
reboot = true,
Copy link
Member

@klutvott123 klutvott123 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a reboot needed for the trim to take effect?

Copy link
Contributor Author

@druckgott druckgott Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's needed. How can I test this?

Thx for all the other informations it's my fist commit,didnt know all the thinks only test it and it works 😉.

What happens if I do Wirte only 1 instead of 1, 2 due to 16 bit?

Copy link
Member

@klutvott123 klutvott123 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"reboot = false". Then try making some changes, save the page and see if it took effect 🙂

What happens is that the pitch field will modify the first byte of pitch trim and the roll field will modify the second byte of pitch trim. So the roll field will make unintended changes to pitch trim, and you won't be able to change roll trim at all

eepromWrite = true,
minBytes = 1,
Copy link
Member

@klutvott123 klutvott123 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this message we need at least 4 bytes to be able to do anything.

labels = labels,
fields = fields,
}
4 changes: 4 additions & 0 deletions src/SCRIPTS/BF/pages.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,8 @@ if apiVersion >= 1.41 then
PageFiles[#PageFiles + 1] = { title = "GPS PIDs", script = "gpspids.lua" }
end

if apiVersion >= 1.16 then
PageFiles[#PageFiles + 1] = { title = "Trim Accelerometer", script = "acc_calibrate.lua" }
Copy link
Member

@klutvott123 klutvott123 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe "acc_trim.lua" would be a more appropriate filename since we already have similarly named files to calibrate the accelerometer.

end

return PageFiles