Skip to content

CMS fixes #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

CMS fixes #424

merged 1 commit into from
Jan 17, 2022

Conversation

@klutvott123
Copy link
Member

@klutvott123 klutvott123 commented Jan 16, 2022

Various fixes for the CMS script.

  • Removed double buffering for incoming data. It's not needed
  • Removed some redundant tests
  • Removed clearing of screen buffer so that it can be drawn multiple times
  • Made some global variables local
  • Fixed retry timeout reset
  • Draw screen two times instead of one to avoid flickering on colour LCDs that use double buffering

For testing
betaflight-tx-lua-scripts_1.5.0.zip

@klutvott123 klutvott123 added this to the 1.6 milestone Jan 16, 2022
haslinghuis
haslinghuis approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Taranis X9D+ ACCST

@haslinghuis haslinghuis merged commit 882f662 into betaflight:master Jan 17, 2022
@klutvott123 klutvott123 deleted the cms-fixes branch January 17, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

No one assigned

Labels

RN: BUGFIX

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

2 participants

@klutvott123 @haslinghuis