Add menu to the betaflight script when used on OpenTx 2.3 tools screen #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooh, flash! 💯 |
mikeller
previously approved these changes
Oct 10, 2019
raphaelcoeffic
force-pushed
the
tools-screen-menu
branch
from
5c1ba0c to
fb8c515
Compare
|
@frozenskys rebased as well. Can you please check I did not break anything? Please note you will have to "force pull", or "reset hard" on the remote ref to have the latest version and not effect a merge. |
mikeller
approved these changes
Oct 10, 2019
mikeller
approved these changes
Oct 10, 2019
Fix double events (betaflight#245)
|
Tested and it seems to work. To me is a little unintuitive to press exit to go the menu, I supposed this will be done with the menu key, but this key cycles the betaflight pages, like in the telemetry script. So it seems the menu is an intro page and the exis is a backward key. Is ok, only I need to use it more :) |
frozenskys
force-pushed
the
tools-screen-menu
branch
from
fb8c515 to
51c1098
Compare
Merged
mikeller
added a commit
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a menu to the betaflight script when run from the tools screen, but not when run as a telemetry script. Needs #253 merged first.