feat: use modules instead of global bindings

[chmelevskij]

• Remove things attached to window global object.
• Use esm imports for some of the node_modules.
• Add new eslint rules. no-undef and no-duplicate-imports.
• Move some of the helpers into their own files to avoid circular deps.
• Fix few bugs which were using un existing variables.

[haslinghuis]

Tested. Upon opening OSD tab:

osd.js:3234 Uncaught (in promise) TypeError: $(...).jBox is not a function
    at HTMLDivElement.<anonymous> (osd.js:3234:56)
    at Function.each (jquery.min.js:2:3003)
    at S.fn.init.each (jquery.min.js:2:1481)
    at osd.js:3233:35

[chmelevskij]

@haslinghuis fixed now

[haslinghuis]

🙃 getting same error 😋

[blckmn]

I'd like to get this in and release RC5 ASAP (for the motors tab issue).

@chmelevskij I think this should be the last one done for 10.9. Anything else needs to be done in the next version please.

[blckmn]

@chmelevskij in addition your new files are named using Snake Case. Please update to Camel Case. The bulk of the files are Camel Case already and you should maintain consistency.

For the next release I will update all files to be Camel Case.

[chmelevskij]

Update file names. I'll be working on some draft branch in the meantime.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.4% Duplication

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[haslinghuis]

Problem is on 3rd line: uncaught (in promise) TypeError: $(...).jBox is not a function

                    // Generate tooltips for OSD elements
                    $('.osd_tip').each(function() {
                        OSD.data.tooltips.push($(this).jBox('Tooltip', {
                            delayOpen: 100,
                            delayClose: 100,
                            position: {
                                x: 'right',
                                y: 'center',
                            },
                            outside: 'x',
                        }));
                    });

EDIT: Fixed in https://github.com/betaflight/betaflight-configurator/pull/3248

[wKich]

Wow, that's awesome change!