Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from motors tab and back resets the motor status #4160

Closed
dmak opened this issue Sep 7, 2024 · 6 comments · Fixed by #4188
Closed

Switching from motors tab and back resets the motor status #4160

dmak opened this issue Sep 7, 2024 · 6 comments · Fixed by #4188
Labels

Comments

@dmak
Copy link

dmak commented Sep 7, 2024

To Reproduce

  • Go to Motors tab. Tick "I understand the risks" and start motors using "Master" slider.
  • Switch to Power & Battery tab. In my case I needed to start motors to calibrate the current for medium throttle.
  • Switch back to Motors tab.

Result

  • There is motors hiccup. Probably due to tab initialization.
  • "I understand the risks" is off, master slider is at zero (motors are still rotating).

Expected behavior

  • There is no motors hiccup.
  • "I understand the risks" is on, master slider (or individual motors) positions are remembered.

Configurator version

v10.10.0

@dmak dmak changed the title When switched back from motors tab and back resets the motor status When switched from motors tab and back resets the motor status Sep 7, 2024
@dmak dmak changed the title When switched from motors tab and back resets the motor status Switching from motors tab and back resets the motor status Sep 7, 2024
@haslinghuis
Copy link
Member

Define hiccup in relation to positions are remembered.
Following is before and after saving settings on power tab.

image

@dmak
Copy link
Author

dmak commented Sep 8, 2024

I have probably messed up with initial description. Try these steps:

  • Switch on motors on "Motors" tab.
  • Go to "Power & Battery" tab. Make tiny change e.g. to voltage and press "Save" (probably will work on other tab as well). Result: FC beeps and motors stop.
  • Switch to "Motors" tab. "I understand the risks" is on, master slider is not zero (Betaflight thinks motors are rotating). Expected: master slider is at zero.

@nerdCopter
Copy link
Member

nerdCopter commented Sep 9, 2024

i believe the motors tab is designed not to reset the motors (sliders) so that a pilot could use other tabs for viewing. especially useful is the sensors tab. however, the action of saving has corrupted the environment.

i wonder if resetting some global motor variable when MSP is saved would be a solution.

@haslinghuis
Copy link
Member

@dmak pls check #4188

@dmak
Copy link
Author

dmak commented Oct 3, 2024

@dmak pls check #4188

So far looks good. Have to tried/checked switching between tabs when motors are on? Does it work smoothly?

@haslinghuis
Copy link
Member

That part has not been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants