Do not use keys in DocumentPersister calls to Cursor::toArray()

Allowing iterator_to_array() to use document "_id" fields as array keys is problematic when documents have non-scalar keys (e.g. embedded objects or MongoBinData, which seems to always return "<Mongo Binary Data>" as its string value). See doctrine#854 for more context.

This change also reverts ec69eaa from doctrine#401. Technically, inverse side relationships should be read-only, so there should be no reason for a set strategy. The previous behavior was also inconsistent with owning side relationships, which used keys from the actual array/object containing the references (not the "_id" fields of the referenced documents).

Author: jmikola

lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php

@@ -692,7 +692,7 @@ private function loadReferenceManyCollectionOwningSide(PersistentCollection $col
             if ( ! empty($hints[Query::HINT_READ_PREFERENCE])) {
                 $cursor->setReadPreference($hints[Query::HINT_READ_PREFERENCE], $hints[Query::HINT_READ_PREFERENCE_TAGS]);
             }
-            $documents = $cursor->toArray();
+            $documents = $cursor->toArray(false);
             foreach ($documents as $documentData) {
                 $document = $this->uow->getById($documentData['_id'], $class);
                 $data = $this->hydratorFactory->hydrate($document, $documentData);
@@ -708,14 +708,9 @@ private function loadReferenceManyCollectionOwningSide(PersistentCollection $col
     private function loadReferenceManyCollectionInverseSide(PersistentCollection $collection)
     {
         $query = $this->createReferenceManyInverseSideQuery($collection);
-        $documents = $query->execute()->toArray();
-        $mapping = $collection->getMapping();
+        $documents = $query->execute()->toArray(false);
         foreach ($documents as $key => $document) {
-            if ($mapping['strategy'] === 'set') {
-                $collection->set($key, $document);
-            } else {
-                $collection->add($document);
-            }
+            $collection->add($document);
         }
     }
 
@@ -764,7 +759,7 @@ public function createReferenceManyInverseSideQuery(PersistentCollection $collec
     private function loadReferenceManyWithRepositoryMethod(PersistentCollection $collection)
     {
         $cursor = $this->createReferenceManyWithRepositoryMethodCursor($collection);
-        $documents = $cursor->toArray();
+        $documents = $cursor->toArray(false);
         foreach ($documents as $document) {
             $collection->add($document);
         }