Skip to content

Commit 291fcbc

Browse files
authored
Update updateip.py
use raise_for_status() to handle requests exceptions
1 parent ef55577 commit 291fcbc

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

restconf_update_ipaddress/updateip.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,11 @@ def get_configured_interfaces(url_base, username, password):
5151
headers=headers,
5252
verify=False
5353
)
54+
response.raise_for_status()
5455
except Exception as e:
5556
print(e, file=sys.stderr)
5657
sys.exit(1)
5758

58-
if response.status_code >= 300:
59-
print('request error:', str(response.status_code), response.reason, file=sys.stderr)
60-
sys.exit(1)
61-
6259
# return the json as text
6360
return response.json()["ietf-interfaces:interfaces"]["interface"]
6461

@@ -94,14 +91,11 @@ def configure_ip_address(url_base, interface, ip, username, password):
9491
verify=False,
9592
json=data
9693
)
94+
response.raise_for_status()
9795
except Exception as e:
9896
print(e, file=sys.stderr)
9997
sys.exit(1)
10098

101-
if response.status_code >= 300:
102-
print('request error:', str(response.status_code), response.reason, file=sys.stderr)
103-
sys.exit(1)
104-
10599
print(response.text)
106100

107101

@@ -116,15 +110,11 @@ def print_interface_details(url_base, interface, username, password):
116110
headers=headers,
117111
verify=False
118112
)
113+
response.raise_for_status()
119114
except Exception as e:
120115
print(e, file=sys.stderr)
121116
sys.exit(1)
122117

123-
if response.status_code >= 300:
124-
print('request error:', str(response.status_code), response.reason, file=sys.stderr)
125-
sys.exit(1)
126-
127-
128118
intf = response.json()["ietf-interfaces:interface"]
129119
# return the json as text
130120
print("Name: ", intf[0]["name"])

0 commit comments

Comments
 (0)