Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR comment indicator missing on some files in the tree and not clickable #185

Open
MahatmaFatalError opened this issue Nov 23, 2021 · 2 comments
Open

PR comment indicator missing on some files in the tree and not clickable #185

MahatmaFatalError opened this issue Nov 23, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@MahatmaFatalError
Copy link

According to #8 a speech bubble should appear on files in the tree that have comments and a click on it (the speech bubble icon) should jump to the first comment in the file.

However,
1st, this icon is just appearing on java files. I also have large json files with comments but there no icon appears.
2nd, the icon is not clickable.

I am using v1.0.35 on latest firefox.
@berzniz
Copy link
Owner

berzniz commented Jan 7, 2022

Hi @MahatmaFatalError , thanks for the feedback.

Can you share a link to a public PR that shows the 1st + 2nd issue?

I'm also open to PRs for fixing it.

@berzniz berzniz added the help wanted Extra attention is needed label Jan 7, 2022
@MahatmaFatalError
Copy link
Author

MahatmaFatalError commented Jan 8, 2022 •
edited
Loading

Sure, regarding 1st issue see #189 and for the 2nd see #190

edit: actually you can see both in #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berzniz @MahatmaFatalError