Conversation
|
I've added some extra commits because PHPstorm was complaining about return values for consumer methods and the possibility inside invoke of rejectDispatch() throwing again. The essence is consumer not declaring ticks and driver using time_nanosleep() to make it interruptable. The nanosleep needs to be ported to the other drivers which i can't test (mongo, reddis, etc) |
acrobat
left a comment
acrobat
left a comment
There was a problem hiding this comment.
The code looks good to me! @GDmac can you explain a bit what the difference is between the ticks and pcntl_signal_dispatch? Does the current test suite cover this code/change enough or should we add an extra test to make sure we don't break the current setup?
|
See my comments (before making this branch :-D) #306 (comment) |
|
Thanks @GDmac! Ok for me @sagikazarmark 👍 |
- deprecated assertDirectoryNotExists => assertDirectoryDoesNotExist - add missing property private $BaseDir
|
rebased on current master |
2 participants
Use pcntl_signal_dispatch instead of declare ticks which has lots of overhead.