Add start gate abort window to publish workflow#144
Merged
Conversation
Gate the entire pipeline behind a single 'startgate' GitHub Environment so any run can be cancelled (push, PR, tag, workflow_dispatch) before runner-heavy jobs start. Wait duration lives in the environment's Wait timer setting (currently 15 min), so changing it requires no YAML edit. Naming leaves room for future gates (e.g. releasegate).
Review SummaryThis PR implements a cancellable abort window for the publish workflow using GitHub's Environment wait timer feature. The implementation is sound and follows GitHub Actions best practices. Strengths:
Operational Requirements:
Recommendation: Document this setup requirement in CONTRIBUTING guide so operators know it needs explicit configuration. No code issues found. Ready to merge pending environment setup verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable "start gate" job to the publish workflow that creates a cancellable abort window before the pipeline begins. This allows developers to cancel the workflow during a grace period after triggering it, before any actual build work starts.
Changes
startgatejob: A simple job that runs onubuntu-latestusing thestartgateGitHub Environment, which has a configurable wait timer (configured in repository Settings → Environments → startgate → Wait timer)needs: startgatedependency to all 10 downstream jobs:crosscompile-linux-x86_64-cudacrosscompile-linux-x86_64crosscompile-linux-aarch64crosscompile-android-aarch64build-macos-arm64-no-metalbuild-macos-arm64-metalbuild-windows-x86_64build-windows-x86test-cpp-linux-x86_64test-macos-arm64-metal-15Implementation Details
The
startgatejob is a minimal gate that simply echoes a message upon completion. The actual abort window is enforced by GitHub's environment wait timer feature, which pauses job execution until the timer expires or is manually approved. This provides a safety mechanism to catch and cancel unintended workflow runs before expensive cross-compilation and testing jobs begin.https://claude.ai/code/session_01TGzxSDP2uzsGiJupDsNad1