Upgrade llama.cpp from b9151 to b9172#143
Conversation
Also adds LLAMA_BUILD_WEBUI=OFF before FetchContent to prevent the new build-time WebUI asset download introduced in b9172 from running during CI/local builds. No JNI-level API changes were required. https://claude.ai/code/session_01DVizDEtXBVDaXciEoo9a8v
Review Summary✅ Strengths
|
| set(GGML_FMA ON CACHE BOOL "" FORCE) | ||
| set(GGML_F16C ON CACHE BOOL "" FORCE) | ||
| set(GGML_AVX512 OFF CACHE BOOL "" FORCE) | ||
| set(LLAMA_BUILD_WEBUI OFF CACHE BOOL "" FORCE) |
There was a problem hiding this comment.
Consider whether LLAMA_USE_PREBUILT_WEBUI also needs to be disabled. According to CLAUDE.md, upstream defaults to LLAMA_USE_PREBUILT_WEBUI=ON which downloads prebuilt WebUI assets. Setting LLAMA_BUILD_WEBUI=OFF prevents building from source, but the prebuilt download might still occur. If the goal is to fully avoid network I/O, you may also need:
set(LLAMA_USE_PREBUILT_WEBUI OFF CACHE BOOL "" FORCE)Or confirm that LLAMA_BUILD_WEBUI=OFF alone is sufficient to prevent all WebUI asset provisioning.
Summary
Upgrades the pinned llama.cpp version from b9151 to b9172 and adds necessary build configuration to handle upstream changes in WebUI asset provisioning.
Changes Made
GIT_TAGfromb9151tob9172and addedset(LLAMA_BUILD_WEBUI OFF CACHE BOOL "" FORCE)to disable WebUI asset building (upstream now provisions assets at build time via HF bucket by default)clip_has_whisper_encoder()removed from public API (no project impact)LLAMA_BUILD_WEBUI=OFFcommon_params::webuidefault made conditional onLLAMA_WEBUI_DEFAULT_ENABLEDmacrocommon_reasoning_budget_clone(no API change)Implementation Details
The
LLAMA_BUILD_WEBUI=OFFcache variable is set beforeFetchContent_MakeAvailable()to prevent upstream from downloading WebUI assets during the build. This aligns with the project's build strategy and avoids unnecessary network I/O.All upstream changes are either internal (CUDA backend, server implementation) or non-breaking for the Java bindings. No JNI code modifications required.
https://claude.ai/code/session_01DVizDEtXBVDaXciEoo9a8v