Add tracking link for llama.cpp reasoning_budget_tokens bug#141
Conversation
Review SummaryThis PR adds tracking links to llama.cpp PR #23116 in the Javadoc comments for two reasoning-budget integration tests. The changes are minimal, focused, and correct. Strengths✅ Clear tracking — Links directly to the upstream fix PR, improving maintainability for future developers No issues found
Recommendation: Approve and merge. This is a straightforward documentation improvement that helps future maintainers understand the context and next steps when the upstream bug is fixed. |
Summary
Added references to the upstream llama.cpp issue tracking the
reasoning_budget_tokensparameter bug in test documentation.Changes
testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed()testtestReasoningBudgetZero_expectedBehavior_suppressesThinking()testDetails
These changes improve test maintainability by explicitly linking the known llama.cpp bug (where per-request
reasoning_budget_tokensis overwritten by model default inoaicompat_chat_params_parse) to its upstream tracking issue. This helps future maintainers understand:https://claude.ai/code/session_01FbMXaE5XHF4JAJ68NwkYdA