Skip to content

Add tracking link for llama.cpp reasoning_budget_tokens bug#141

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/add-pending-unit-test-R2tO3
May 15, 2026
Merged

Add tracking link for llama.cpp reasoning_budget_tokens bug#141
bernardladenthin merged 1 commit into
mainfrom
claude/add-pending-unit-test-R2tO3

Conversation

@bernardladenthin
Copy link
Copy Markdown
Owner

Summary

Added references to the upstream llama.cpp issue tracking the reasoning_budget_tokens parameter bug in test documentation.

Changes

  • Added tracking link to llama.cpp PR #23116 in the JavaDoc comment for testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed() test
  • Added the same tracking link to the JavaDoc comment for testReasoningBudgetZero_expectedBehavior_suppressesThinking() test

Details

These changes improve test maintainability by explicitly linking the known llama.cpp bug (where per-request reasoning_budget_tokens is overwritten by model default in oaicompat_chat_params_parse) to its upstream tracking issue. This helps future maintainers understand:

  1. Why the workaround test exists
  2. When the bug is fixed (the PR will be merged)
  3. What action to take when the fix is released (remove the workaround test and enable the expected behavior test)

https://claude.ai/code/session_01FbMXaE5XHF4JAJ68NwkYdA

@claude
Copy link
Copy Markdown

claude Bot commented May 15, 2026

Review Summary

This PR adds tracking links to llama.cpp PR #23116 in the Javadoc comments for two reasoning-budget integration tests. The changes are minimal, focused, and correct.

Strengths

Clear tracking — Links directly to the upstream fix PR, improving maintainability for future developers
Proper placement — Links are positioned at the end of the detailed bug explanation, right before the call-to-action ("remove this test")
Consistent with style — HTML anchor tags follow Javadoc conventions; no new HTML entity issues introduced
Low risk — Documentation-only change with no impact on build, tests, or runtime behavior
Addresses real need — These tests are explicitly marked with @ignore and need external context; linking to the upstream tracking issue is practical

No issues found

  • No typos or formatting errors
  • URLs are valid HTTPS links to the official ggml-org/llama.cpp repository
  • Both methods affected by the same bug receive consistent documentation
  • Changes align with the existing detailed Javadoc explanations

Recommendation: Approve and merge. This is a straightforward documentation improvement that helps future maintainers understand the context and next steps when the upstream bug is fixed.

@bernardladenthin bernardladenthin merged commit 7b8bfdb into main May 15, 2026
4 of 13 checks passed
@bernardladenthin bernardladenthin deleted the claude/add-pending-unit-test-R2tO3 branch May 15, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants