Skip to content

Conversation

canewsin
Copy link
Contributor

No description provided.

@bernaferrari
Copy link
Owner

Does this help you in any way or is it just code cosmetic?

@canewsin
Copy link
Contributor Author

increases code gen speed for large components and frames.

@bernaferrari
Copy link
Owner

Via log level? Because there shouldn't be any difference right?

@canewsin
Copy link
Contributor Author

yup, codebase has many console.log/warn statements, we may forgot to remove and it's not trival to comment and uncomment all the time while development. with this loglevel variable we can toggle log and can also change that on release builds.

@bernaferrari
Copy link
Owner

I like it, sorry if it is slow, I should probably fix that.

If we do something like:

const originalLog = console.log;
console.log = function(...args) {
    originalLog.apply(console, ["Node log:", ...args]);
};

then we don't need to override it everywhere/import everywhere and can be the best of both worlds. I'll try this solution.

@canewsin
Copy link
Contributor Author

@bernaferrari

@canewsin
Copy link
Contributor Author

@bernaferrari pushed with suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants