Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup tag breaks output renderer #1076

Open
Bilge opened this issue Mar 19, 2017 · 7 comments
Open

Markup tag breaks output renderer #1076

Bilge opened this issue Mar 19, 2017 · 7 comments
Labels

Comments

@Bilge
Copy link

Bilge commented Mar 19, 2017

Heading 1
---------

<div>

Heading 2
---------

</div>

Heading 3
---------

Everything before and everything inside the div does not render in the output pane. Heading 3 renders normally. On GitHub all three render normally.

@benweet
Copy link
Owner

benweet commented Oct 2, 2017

Closing this. Please open a new ticket if the problem still exists in the v5 (https://stackedit.io/app).

@benweet benweet closed this as completed Oct 2, 2017
@Bilge
Copy link
Author

Bilge commented Oct 2, 2017

@benweet Thanks for working on a fix in the new version. LGTM 👍

However, in my particular case I am using the align="center" attribute on the div tag, which does not cause the text inside the div to become centered even though it does on GitHub. Do you want to support the align attribute or not?

Aside, I also noticed large images that do not fit the editor's viewport are not scaled down in the new version any more (they are rendered 1:1 causing it to flow off the screen). Do you want me to create an issue to track this or are you still working on it?

@benweet
Copy link
Owner

benweet commented Oct 2, 2017

This works fine to me in the v5:

<div align="center">
Centered
</div>

Ok for the scale down of the images. It will be fixed in the next release.

@Bilge
Copy link
Author

Bilge commented Oct 2, 2017

Yessir, that does indeed work. Here's where it doesn't, though:

<div align="center">

## Heading

Body

</div>

I suspect it may be a consequence of mixing markup and markdown.

@benweet
Copy link
Owner

benweet commented Oct 2, 2017

Yes absolutely, though you can have what you want with plain HTML:

<h2 align="center">Heading</h2>

<div align="center">
Body
</div>

@Bilge
Copy link
Author

Bilge commented Oct 2, 2017

Again, and I hate to imply it's some kind of gold standard (because it's not), but it is working on GitHub as I wrote it. Since I am ostensibly writing in markdown I prefer to use the minimum amount of markup necessary.

I am indifferent as to whether you choose to support this curious mix of the two syntaxes. In v4 it did not render at all (or it caused the rest of the document to become corrupted) which was a critical issue. In v5 the only problem is it's not centred, which is not really a big problem for me, and I understand if you have more important things to do. Nevertheless it would be nice if it did work the same way as on GitHub ;)

@benweet
Copy link
Owner

benweet commented Oct 2, 2017

Ok that's a bug..

@benweet benweet reopened this Oct 2, 2017
@benweet benweet added the bug label Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants