Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Observability enhancement in tracing and logging #3818

Closed
ssheng opened this issue May 2, 2023 · 2 comments
Closed

feat: Observability enhancement in tracing and logging #3818

ssheng opened this issue May 2, 2023 · 2 comments
Assignees

Comments

@ssheng
Copy link
Collaborator

ssheng commented May 2, 2023

The community made the following suggestions to BentoML observability.

  1. Add a configuration option to return the trace id in the response as a header.

Consider adding a traceparent header that includes the trace id in the response. I only found mentioning of such protocol by vendors, such as https://uptrace.dev/opentelemetry/opentelemetry-traceparent.html, but not any official OpenTelemetry documentation.

  1. Add service.name=%(otelServiceName)s in logs generated.

otelServiceName should be configurable through an environment variable. Possibly through the OTEL_SERVICE_NAME environment name, open-telemetry/opentelemetry-specification#1677, and default to the bento name. Evaluate adding OTEL_RESOURCE_ATTRIBUTES to include any arbitrary KVPs to be logged. https://opentelemetry.io/docs/reference/specification/sdk-environment-variables/

@ssheng ssheng changed the title dri: Observability enhancement in tracing and logging enhance: Observability enhancement in tracing and logging May 2, 2023
@ssheng ssheng changed the title enhance: Observability enhancement in tracing and logging feat: Observability enhancement in tracing and logging May 2, 2023
@aarnphm
Copy link
Contributor

aarnphm commented May 4, 2023

number 2 addressed by #3825

@aarnphm
Copy link
Contributor

aarnphm commented May 4, 2023

Number 1 addressed by #3827

@ssheng ssheng closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants