add support for eventlets _AlreadyHandled object

[stefaang]

fixes #1210

[Hum4n01d]

Does this just silence the error?

[benoitc]

thanks for the patch. but such changes must be done in the eventlet worker code since it's specific to it. What about catching an optional value set by the worker? btw Wondering why the lib can't use the gunicorn way that provide a consistent behaviour across worker and doesn't force the usage of eventlet though...has it been discussed?

…

On Wed, 7 Dec 2016 at 01:40, Hum4n01d ***@***.***> wrote: Does this just silence the error? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1406 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA4ov3bjhcd96nALnar1RhT_bVI4gluks5rFgCYgaJpZM4LFhXG> .

[stefaang]

@Hum4n01d The error was caused by an empty wsgi response on disconnect, due to a slightly different implementation of the _AlreadyHandled object. The goal of _AlreadyHandled is to raise a StopIteration exception to close the socket.
@benoitc I reworked this into a wrapper around self.wsgi by overloading self.load_wsgi in the geventlet worker.
I'm not that familiar with the all the eventing projects... but this error was messing up my logs so I wanted a quick fix.

[Hum4n01d]

I don't totally get what you're saying but please merge it @benoitc

[benoitc]

@stefaang the change can be simpler imo,

so we check ALREADY_HANDLED there:
https://github.com/benoitc/gunicorn/blob/master/gunicorn/workers/async.py#L104

Instead we could check it using a function is_already_handled that could be overriden by the worker. In the case of Eventlet it would check for both the gunicorn value and the eventlet value. Do you want to make the change?

[stefaang]

You're right, that's a better approach. I'll get around with another fix.

[Hum4n01d]

So can it be merged?

[tilgovi]

This looks good to me.

[benoitc]

merged. Thanks!

[Hum4n01d]

Yay! Now my logs won't be clogged up

[qwexvf]

Thank you for this fix <3