gaiohttpy.py invalid syntax warning (19.0.0)

[hyao]

Thanks for the new release!

Just pip installed gunicorn 19.0.0, it installs all right, but there's the following warning during installation (Python 2.7.6):

File "/usr/local/lib/python2.7/dist-packages/gunicorn/workers/gaiohttp.py", line 67
        yield from self.wsgi.close()
                 ^
    SyntaxError: invalid syntax

Thanks,

[benoitc]

asyncio requires python 3.4 afaik. Not sure what is required to have trollius but any patch is welcome. Maybe we should test the python version and raise an error first though...

cc @fafhrd91 @asvetlov

[hyao]

or we could make asyncio package a requirement for versions other than python 3.4?

[berkerpeksag]

or we could make asyncio package a requirement for versions other than python 3.4?

That would work only for Python 3.3 since tulip works on 3.3+.

[benoitc]

yeah like @berkerpeksag said, asyncio requires Python 3.3 or later: https://pypi.python.org/pypi/asyncio/3.4.1

For python2.7 trollius may do the job but it will require some patching.

[benoitc]

Sorry need more coffee... reverted the commit since it's was not needed. The error is a syntax error happening during install. It is harmless. (

[benoitc]

@hyao if you need its support on python 2.7 with trollius please open a new ticket. Though I strongly suggest you to go on python3 so you won't rely on an hack.

[hyao]

@benoitc I'm just looking at this from a user's perspective, a syntax error during installation makes the user wonder whether the package is installed correctly or not.

As to use python3 for gaiohttp functionality, thanks for the suggestion. I guess it's already been documented somewhere.

Thanks,

[asvetlov]

1. The warning raised on compiling .py files stage.
   To suppress it we need to switch from find_packages in setup.py to manually collecting list of modules. I can take a look on that. No library code should be changed.
2. aiohttp doesn't support trollius and probably will not in the near future, sorry.

[asvetlov]

gaiohttp depends on aiohttp, not asyncio itself.
gunicorn has no requires for tornado, gevent, eventlet etc.
That's why I did not add aiohttp into gunicorn requirements.

[berkerpeksag]

To suppress it we need to switch from find_packages in setup.py to manually collecting list of modules.

This is more like a distutils issue/feature. distutils compiles all Python files to bytecode when installing a package.

[benoitc]

@hyao I agree we should fix it if possible :)

@asvetlov +1 for the changes. While we are here maybe we could remove the setuptools dependency...

[tilgovi]

It's actually easy. We can switch on PY2 and use trollius yield From(...) instead of the yield from ... syntax.

[tilgovi]

It won't do any good unless aiohttp works on PY2 this way, also.