Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make releases from CI #2205

Closed
tilgovi opened this issue Nov 25, 2019 · 9 comments
Closed

Make releases from CI #2205

tilgovi opened this issue Nov 25, 2019 · 9 comments
Assignees
Labels
Discussion good first issue Open for everyone. A good first issue to become familiar with codebase. Improvement release

Comments

@tilgovi
Copy link
Collaborator

tilgovi commented Nov 25, 2019

I was just reading about cibuildwheel1. Do we have any interest in automating releases like this?

@benoitc
Copy link
Owner

benoitc commented Nov 25, 2019

I'm all for automating the release if we can. This looks good for me. Do you think we can do it only when a version is tagged?

@tilgovi
Copy link
Collaborator Author

tilgovi commented Nov 25, 2019

Definitely we can make it happen only when tagged.

@tilgovi
Copy link
Collaborator Author

tilgovi commented Nov 25, 2019

The example in the README contains this code:

  # if the release was tagged, upload them to PyPI
  - |
    if [[ $TRAVIS_TAG ]]; then
      python -m pip install twine
      python -m twine upload wheelhouse/*.whl
    fi

@benoitc
Copy link
Owner

benoitc commented Nov 25, 2019

oh I didn't see it... that's good! I would be more than happy to automate such thing. So no more error and such

@tilgovi
Copy link
Collaborator Author

tilgovi commented Nov 25, 2019

I'll work on it.

@jamadden
Copy link
Collaborator

The zopefoundation repos that I work on recently updated the way they do this. They generate multiple binary wheels for Windows and Linux so the configuration is more complex than what is needed here & now, but it's been iterated on several times and I think it's a good example of using Docker/Linux and macOS. There may be some usable parts there.

Here's one that builds and uploads binaries on Travis. The sibling appveyor.yml is for Windows.

@benoitc
Copy link
Owner

benoitc commented Nov 26, 2019

while we are here we should also test some scenarios on different platforms (signals, reload, reexec..) so we can make sure the code is cross platform. I'm thinking we could create github project for that and collect from there the tickets. Thoughts?

@benoitc benoitc added the good first issue Open for everyone. A good first issue to become familiar with codebase. label May 7, 2023
@benoitc
Copy link
Owner

benoitc commented Aug 6, 2024

no activity since awhile. closing feel free to create a new ticket if needed.

@benoitc benoitc closed this as completed Aug 6, 2024
@pajod
Copy link
Contributor

pajod commented Aug 7, 2024

There is activity in the form of a (in its current state, just going though the motions, not actually releasing) github workflow suggested here in #3134 - see https://github.com/benoitc/gunicorn/pull/3134/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R32-R38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion good first issue Open for everyone. A good first issue to become familiar with codebase. Improvement release
Projects
None yet
Development

No branches or pull requests

4 participants