Create admin session cookie file only in JSON workflow #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the issue #12:
The admin session cookie file is, I believe, needed only to allow backup and restoration of the Ghost JSON export.
So when the backup/restore workflow doesn't involve the Ghost JSON export, the function that create the admin session cookie file should not be invoked.
How is it done?
I've removed invocation to
createGhostAdminCookie()
from the bottom ofcommon.sh
, so it stops being called automatically, even when the-J
option is passed to the backup command.Then, I've added invocation of that function at the top of the blocks where it is needed, namely in the
backupGhostJsonFile()
andrestoreGhostJsonFile()
functions.How to test?
I have added automated unit tests in the
tests/
directory. After installing bats-core, they can be run as shown below: