Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add six.moves.collections.abc #155

Closed
benjaminp opened this issue May 29, 2016 · 7 comments
Closed

Add six.moves.collections.abc #155

benjaminp opened this issue May 29, 2016 · 7 comments
Labels
minor proposal

Comments

@benjaminp
Copy link
Owner

Originally reported by: Eklavya Sharma (Bitbucket: ekujupr, GitHub: Unknown)

I'm fed up of doing

try:
    import collections.abc as collections_abc # only works on python 3.3+
except ImportError:
    import collections as collections_abc

A six.moves.collections.abc would be very convenient.
@WildCard65
Copy link

Bumping this issue as Python 3.7 (once it release) may end up giving a deprecation warning for using classes from collections.abc in collections itself.

Reference: python/cpython#5460

@haikuginger
Copy link

I'm 👍 on this request. With the removal of the collections.abc items from collections in Python 3.8, now is the right time to do this so we can transition appropriately.

Reference: urllib3/urllib3#1324

@WildCard65 WildCard65 mentioned this issue May 11, 2018
Closed
@webknjaz webknjaz mentioned this issue May 13, 2018
Merged
@toslunar toslunar mentioned this issue Jul 13, 2018
Closed
medmunds added a commit to anymail/django-anymail that referenced this issue Aug 27, 2018
@medmunds
Python 3.8 (prep): Import Mapping etc. from collections.abc
cb521e0 
Python 3.3 moved various collections abstract base classes from
`collections` to `collections.abc`, but also kept them available in
`collections` for compatibility with Python 2. Python 3.8 will allow
importing only from `collections.abc`.

(`collections.abc` hasn't yet been added to six.moves; see
benjaminp/six#155.)
@dcecile dcecile mentioned this issue Jan 30, 2019
Closed
@alexcjohnson alexcjohnson mentioned this issue Feb 1, 2019
Closed
@mbarkhau mbarkhau mentioned this issue Feb 13, 2019
Closed
@NeilGirdhar
Copy link

Duplicate of #241

@nickwilliams-eventbrite
Copy link

Duplicate of #241

This is not correct. This is an issue. #241 is a pull request. In fact, #241's comment specifically says that it resolves #155 (this). So ... this is not a duplicate. It's the companion issue to the #241 pull request.

@WildCard65
Copy link

To add onto what @nickwilliams-eventbrite said, should #241 get accepted, GitHub will automatically close this issue as the PR's comment has "closes " in it.

@NeilGirdhar
Copy link

oh right, sorry, was quickly searching for #241, and ran into this in the search.

@NeilGirdhar
Copy link

Although, it is confusing that most of the discussion there is about whether this should be done at all (that discussion should be here, I think).

@kmike kmike mentioned this issue Jul 15, 2019
Merged
@mulkieran mulkieran mentioned this issue Sep 23, 2019
Closed
@graingert graingert mentioned this issue Sep 30, 2019
Closed
pmhahn added a commit to univention/univention-corporate-server that referenced this issue Jul 5, 2020
@pmhahn
squash! Revert "Fix DeprecationWarning: collections.MutableMapping"
2d9ab7a 
This reverts commit 40d511e.

 > Traceback:
 > /usr/lib/python2.7/dist-packages/six.py:709: in exec_
 >     exec("""exec _code_ in _globs_, _locs_""")
 > tests/test_interfaces.py:13: in <module>
 >     from univention.config_registry.interfaces import _Iface, Interfaces, forgiving, cmp_alnum  # noqa E402
 > python/univention/config_registry/__init__.py:33: in <module>
 >     from univention.config_registry.backend import StrictModeException, SCOPE, ConfigRegistry  # noqa F401
 > python/univention/config_registry/backend.py:39: in <module>
 >     from collections.abc import MutableMapping
 > E   ImportError: No module named abc

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn added a commit to univention/univention-corporate-server that referenced this issue Jul 11, 2020
@pmhahn @spaceone
squash! Revert "Fix DeprecationWarning: collections.MutableMapping"
8324ca4 
This reverts commit 40d511e.

 > Traceback:
 > /usr/lib/python2.7/dist-packages/six.py:709: in exec_
 >     exec("""exec _code_ in _globs_, _locs_""")
 > tests/test_interfaces.py:13: in <module>
 >     from univention.config_registry.interfaces import _Iface, Interfaces, forgiving, cmp_alnum  # noqa E402
 > python/univention/config_registry/__init__.py:33: in <module>
 >     from univention.config_registry.backend import StrictModeException, SCOPE, ConfigRegistry  # noqa F401
 > python/univention/config_registry/backend.py:39: in <module>
 >     from collections.abc import MutableMapping
 > E   ImportError: No module named abc

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn added a commit to univention/univention-corporate-server that referenced this issue Jul 11, 2020
@pmhahn @spaceone
squash! Revert "Fix DeprecationWarning: collections.MutableMapping"
a9632a0 
This reverts commit 40d511e.

 > Traceback:
 > /usr/lib/python2.7/dist-packages/six.py:709: in exec_
 >     exec("""exec _code_ in _globs_, _locs_""")
 > tests/test_interfaces.py:13: in <module>
 >     from univention.config_registry.interfaces import _Iface, Interfaces, forgiving, cmp_alnum  # noqa E402
 > python/univention/config_registry/__init__.py:33: in <module>
 >     from univention.config_registry.backend import StrictModeException, SCOPE, ConfigRegistry  # noqa F401
 > python/univention/config_registry/backend.py:39: in <module>
 >     from collections.abc import MutableMapping
 > E   ImportError: No module named abc

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn added a commit to univention/univention-corporate-server that referenced this issue Jul 31, 2020
@pmhahn @spaceone
squash! Revert "Fix DeprecationWarning: collections.MutableMapping"
12537cd 
This reverts commit 40d511e.

 > Traceback:
 > /usr/lib/python2.7/dist-packages/six.py:709: in exec_
 >     exec("""exec _code_ in _globs_, _locs_""")
 > tests/test_interfaces.py:13: in <module>
 >     from univention.config_registry.interfaces import _Iface, Interfaces, forgiving, cmp_alnum  # noqa E402
 > python/univention/config_registry/__init__.py:33: in <module>
 >     from univention.config_registry.backend import StrictModeException, SCOPE, ConfigRegistry  # noqa F401
 > python/univention/config_registry/backend.py:39: in <module>
 >     from collections.abc import MutableMapping
 > E   ImportError: No module named abc

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn added a commit to univention/univention-corporate-server that referenced this issue Jul 31, 2020
@pmhahn @spaceone
squash! Revert "Fix DeprecationWarning: collections.MutableMapping"
dcce7a5 
This reverts commit 40d511e.

 > Traceback:
 > /usr/lib/python2.7/dist-packages/six.py:709: in exec_
 >     exec("""exec _code_ in _globs_, _locs_""")
 > tests/test_interfaces.py:13: in <module>
 >     from univention.config_registry.interfaces import _Iface, Interfaces, forgiving, cmp_alnum  # noqa E402
 > python/univention/config_registry/__init__.py:33: in <module>
 >     from univention.config_registry.backend import StrictModeException, SCOPE, ConfigRegistry  # noqa F401
 > python/univention/config_registry/backend.py:39: in <module>
 >     from collections.abc import MutableMapping
 > E   ImportError: No module named abc

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn added a commit to univention/univention-corporate-server that referenced this issue Aug 10, 2020
@pmhahn @spaceone
squash! Revert "Fix DeprecationWarning: collections.MutableMapping"
4104c7e 
This reverts commit 40d511e.

 > Traceback:
 > /usr/lib/python2.7/dist-packages/six.py:709: in exec_
 >     exec("""exec _code_ in _globs_, _locs_""")
 > tests/test_interfaces.py:13: in <module>
 >     from univention.config_registry.interfaces import _Iface, Interfaces, forgiving, cmp_alnum  # noqa E402
 > python/univention/config_registry/__init__.py:33: in <module>
 >     from univention.config_registry.backend import StrictModeException, SCOPE, ConfigRegistry  # noqa F401
 > python/univention/config_registry/backend.py:39: in <module>
 >     from collections.abc import MutableMapping
 > E   ImportError: No module named abc

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Aug 15, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
f7d77d0 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Aug 21, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
38cdc45 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Aug 21, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
a983369 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Aug 30, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
abbb266 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 10, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
b4a7be5 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 10, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
570d25d 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 11, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
d1e8419 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 11, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
b8accbb 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 11, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
5e38a76 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 11, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
d572adc 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 11, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
1261554 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 14, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
5c84ae2 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 15, 2020
@spaceone
Fix DeprecationWarning: collections.MutableMapping
7ab74ab 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 15, 2020
@spaceone
UCR: Fix DeprecationWarning: collections.MutableMapping
875f01a 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 15, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
a075fee 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
aaf31c0 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
459b0ea 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
a14195b 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
07cdcc1 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
00a75fa 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
d1486b2 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
99acb71 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
78565e0 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 16, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
71fccfd 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 18, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
9ba4b61 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 18, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
d64115f 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 18, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
0af36c9 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 18, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
f78c9cd 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 18, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
5767a9f 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 19, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
338884f 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
@faucomte97 faucomte97 mentioned this issue Sep 21, 2020
Closed
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 21, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
d6c3285 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 21, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
c55aced 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
pmhahn pushed a commit to univention/univention-corporate-server that referenced this issue Sep 21, 2020
@spaceone
Bug #52018 UCR: Fix DeprecationWarning: collections.MutableMapping
66bba75 
DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated, and in 3.8 it will stop
working

There is no six.moves.collections.abc yet:
<benjaminp/six#155>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a six.moves for collections and collections.abc in preparation fo…
5 participants
@benjaminp @NeilGirdhar @WildCard65 @haikuginger @nickwilliams-eventbrite