Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uppercasing of groups #31

Closed
wants to merge 3 commits into from

Conversation

tomrbowden
Copy link

Unlike most fields in forms in Mailchimp, which use uppercase key names (eg: "NAME"), groups do not (eg: "group[2][4]"), so uppercasing them causes them to not be recognized as a group by Mailchimp.

Example:
image

To fix this, a simple check if the key name includes the substring "group[", and if it does, the key is not uppercased.

@benjaminhoffman
Copy link
Owner

wow thanks! this looks good but i'll need about a week to test it locally first. hope that's okay? thanks so much for the PR! 👍

@tomrbowden
Copy link
Author

wow thanks! this looks good but i'll need about a week to test it locally first. hope that's okay? thanks so much for the PR! 👍

Sure, happy in any way to help.

@benjaminhoffman
Copy link
Owner

@tomrbowden working on this today. looks like you are using prettier to format the code? i may need to simply make this change myself and commit it normally (instead of merging your PR).

if you prefer, you can make a new diff that adds prettier to this lib so that this diff is much smaller.

either way, hoping to get this solved / fix today. be in touch.

@benjaminhoffman
Copy link
Owner

solved! 7f73fd8

closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants