Skip to content

Commit 74174d6

Browse files
committed
dns: use template literals
Prefer the use of template string literals over string concatenation in the dns module, makes dns consistent with other modules basically doing nodejs#5778 for it. PR-URL: nodejs#5809 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f158a86 commit 74174d6

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/dns.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ function errnoException(err, syscall, hostname) {
2525
}
2626
var ex = null;
2727
if (typeof err === 'string') { // c-ares error code.
28-
ex = new Error(syscall + ' ' + err + (hostname ? ' ' + hostname : ''));
28+
const errHost = hostname ? ' ' + hostname : '';
29+
ex = new Error(`${syscall} ${err}${errHost}`);
2930
ex.code = err;
3031
ex.errno = err;
3132
ex.syscall = syscall;
@@ -272,7 +273,7 @@ exports.resolve = function(hostname, type_, callback_) {
272273
if (typeof resolver === 'function') {
273274
return resolver(hostname, callback);
274275
} else {
275-
throw new Error('Unknown type "' + type_ + '"');
276+
throw new Error(`Unknown type "${type_}"`);
276277
}
277278
};
278279

@@ -310,7 +311,7 @@ exports.setServers = function(servers) {
310311
if (ver)
311312
return newSet.push([ver, s]);
312313

313-
throw new Error('IP address is not properly formatted: ' + serv);
314+
throw new Error(`IP address is not properly formatted: ${serv}`);
314315
});
315316

316317
var r = cares.setServers(newSet);
@@ -320,8 +321,7 @@ exports.setServers = function(servers) {
320321
cares.setServers(orig.join(','));
321322

322323
var err = cares.strerror(r);
323-
throw new Error('c-ares failed to set servers: "' + err +
324-
'" [' + servers + ']');
324+
throw new Error(`c-ares failed to set servers: "${err}" [${servers}]`);
325325
}
326326
};
327327

0 commit comments

Comments
 (0)