Skip to content

Commit

Permalink
stream: revert map spec compliance
Browse files Browse the repository at this point in the history
PR-URL: nodejs#41931
Fixes: nodejs#41926
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
benjamingr authored and bengl committed Feb 21, 2022
1 parent 3ddbe6e commit a89a853
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ for (const key of ObjectKeys(streamReturningOperators)) {
value: fn,
enumerable: false,
configurable: true,
writable: false,
writable: true,
});
}
for (const key of ObjectKeys(promiseReturningOperators)) {
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-stream-iterator-helpers-test262-tests.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ import assert from 'assert';
);
assert.strictEqual(descriptor.enumerable, false);
assert.strictEqual(descriptor.configurable, true);
assert.strictEqual(descriptor.writable, false);
// assert.strictEqual(descriptor.writable, false);
}
{
// drop/length
Expand All @@ -79,7 +79,7 @@ import assert from 'assert';
);
assert.strictEqual(descriptor.enumerable, false);
assert.strictEqual(descriptor.configurable, true);
assert.strictEqual(descriptor.writable, false);
// assert.strictEqual(descriptor.writable, false);
// drop/limit-equals-total
const iterator = Readable.from([1, 2]).drop(2);
const result = await iterator[Symbol.asyncIterator]().next();
Expand Down

0 comments on commit a89a853

Please sign in to comment.