Skip to content
This repository has been archived by the owner on Jan 5, 2022. It is now read-only.

I have used cat demo. When I scroll slowly towards header i can see entire scroll view getting vibrated. Could you please tell me how to fix it #62

Closed
Pamu2018 opened this issue Jan 29, 2019 · 19 comments
Labels
bug-react-native help wanted Extra attention is needed

Comments

@Pamu2018
Copy link

No description provided.

@benevbright
Copy link
Owner

Hi, thanks for your issue.
It's actually a bug from react-native and it occurs only on Android.

Check those out.
facebook/react-native#15445
facebook/react-native#19725

Hi, I'm looking into it, though.

@benevbright
Copy link
Owner

benevbright commented Jan 31, 2019

facebook/react-native#15445 (comment)

Here is a workaround and it works. I will write postinstall script for example.

Edit:

No workaround so far. This bug still remains.
facebook/react-native#21801

@benevbright
Copy link
Owner

Unfortunately, I was wrong.
It doesn't seem to a workaround.

@benevbright benevbright added the help wanted Extra attention is needed label Feb 4, 2019
@benevbright
Copy link
Owner

@davidkalosi
Copy link

hi @benevbright any new development on that issue?

@Ashish-ish
Copy link

HI @benevbright any updates

@ddedic
Copy link

ddedic commented Feb 28, 2019

+1

@benevbright
Copy link
Owner

benevbright commented Mar 8, 2019

Hi.
Sorry, this issue is not fixed yet on react-native.
I was thinking to fix react-native but I couldn't manage time for that.
Tbh, I'm also still waiting 😢
facebook/react-native#21801

@alz10
Copy link

alz10 commented Mar 17, 2019

any solution for this?

@benevbright
Copy link
Owner

@Albert0405 Hi,
I saw your comment on react-native issue. facebook/react-native#21801 (comment)

I really appreciate.
But unfortunately, it doesn't work for this module. I tried that aproach already though and I gave a shot today again but no luck.

Could you test your code with the example of this module?
You can test it by simply modify the code in node_modules/react-navigation-collapsible/index.js.

<Animated.View style={{ flex: 1, marginTop: paddingHeight, marginBottom: -paddingHeight, transform: [{ translateY }] }}>
<MaterialTopTabNavigator
screenProps={this.props}
navigation={this.props.navigation}
/>
</Animated.View>

I tried changing here like below.

<Animated.View style={{ position: 'absolute', width: '100%', height: '100%', zIndex: 999, top: 0, marginTop: paddingHeight, marginBottom: -paddingHeight, transform: [{ translateY }] }}>
              <MaterialTopTabNavigator
                screenProps={this.props}
                navigation={this.props.navigation}
              />
            </Animated.View>

@brunohkbx
Copy link

Hey @benevbright, any update on this?
I had to implement this feature but this flickering problem made it not suitable for a production release :(

@fokoz
Copy link

fokoz commented Jul 12, 2019

Animation when collapsing is very laggy and shaking even on iOS, does anyone face this ?

@kartikpr
Copy link

Any updates?

@benevbright
Copy link
Owner

I heard it's fixed on RN 60.4. react-native-community/releases#130 (comment)
(But other says it's not. I guess I need to test)
I'll make some time for testing this (maybe weekend).

@kartikpr
Copy link

I hope its got fixed, thanks for the prompt reply.
Please keep us posted.

@benevbright
Copy link
Owner

I just updated example's react-native to 0.60.5 which is latest.
But the issue is still happening. I'm sorry about it.

GIF

Aug-18-2019 6-19-48 PM

@vinodache
Copy link

Hey, I do not have a fix yet but was wondering how twitter or instagram handled the similar widget in their UX. I thought they use react native too. Any one has an idea. For instance both twitter and instagram uses a sticky tab with a scrollable header.

Cheers
Vinod

@benevbright
Copy link
Owner

@vinodache I think it only works without having translateY on the ScrollView/Flatlist. There is no way to resolve this without the real fix from RN.
I can only guess that they're using paddingTop instead.
But I can't do that because we're using react-navigation's tab navigator.

@benevbright
Copy link
Owner

The bug never gets fixed on React Native.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-react-native help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

10 participants