WIP: Operators for non-orthogonal meshes #88
+470
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A version of FV::Div_a_Grad_perp that includes all metric components, including g12 (X-Y non-orthogonal) and g13 (X-Z nonorthogonal) terms. Aim to test and then merge upstream into BOUT++
Testing, using operator that includes nonorthogonal mesh corrections
|
I have written a small MMS test and have been running it for the div_a_grad_perp_nonorthog, but it does not seem to converge:
For reference, the Delp2 operator: I am trying to check zoidberg is correct, so the bug might be in zoidberg, but as Delp2 passes, I thought I mention it ... The test converges if the grid is orthogonal, but fails otherwise. |
|
@dschwoerer Michael Hardman started with us and will be taking a look at this, do you mind sharing your MMS test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including off-diagonal metric terms coming from non-orthogonal meshes. Starting with operators in neutral fluid model as those are likely to have the most impact.