Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-Boussinesq vorticity #56

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Non-Boussinesq vorticity #56

wants to merge 5 commits into from

Conversation

johnomotani
Copy link
Collaborator

[Replaces #54 to use the branch on this repo]

Mostly copy-paste of bendudson/hermes-2#44.

Not sure about the multi-species aspects... Have just replaced Ne with N_sum and Pi with Pi_sum. Is this the right thing to do @bendudson?

Needs documentation.

Thanks @johnomotani ! Some things I'm unsure about:

  • I think N_sum should be the mass density, so the sum of AA * N for all species which have a charge
  • The average_atomic_mass setting needs thinking about: At the moment it defaults to 2, which is probably not the right choice. When the Boussinesq approximation is not used this setting should not affect the result, so possibly should not be read at all.
  • The energy source term, which picks up a factor of N in non-Boussinesq case. I suspect this should be N_sum rather than N: If it's just N then the energy transferred to a species only depends on its temperature and is independent of its density. In the Boussinesq approximation the sum of AA * N is replaced with average_atomic_mass (total N normalised to 1) so I think this is consistent.

johnomotani and others added 5 commits September 7, 2022 16:56
@johnomotani
Add option to use non-Boussinesq vorticity
075ac96
@bendudson
Minor changes to vorticity manual entry
b6776b3 
`\overline` doesn't show on Sphinx; trying `\bar`
@bendudson
Set average_atomic_mass to 1 if boussinesq=false
3904f2f 
Only needed if Boussinesq approximation is made
@bendudson
vorticity component formatting
60c1ef3 
Applying Clang format
@bendudson
N_sum is mass density
9b9ba7d 
Weighted by a factor of the atomic mass. average_atomic_mass used
for consistency with other equations, but is set to 1 if
`boussinesq=false`
@johnomotani johnomotani added the enhancement New feature or request label Sep 8, 2022
@johnomotani johnomotani mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnomotani @bendudson