Implement non-Boussinesq case #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only works with 'old-style' phiSolver.
johnomotani
commented
Sep 7, 2022
phiSolver must support 3D coefficients (i.e. multigrid or naulin).
johnomotani
force-pushed
the
non-Boussinesq
branch
from
ec1d6ba
to
c9c24ab
Compare
This was referenced Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does run (for a 2d turbulence case). Needs checking/validating. Only implemented for 'old-style' phiSolver and
split_n0is not supported.Added one term to vorticity equation (from Simakov&Catto2003) involving
V_ExB.Grad(n)- see updated manual. Also changed n_0->n in a couple more places in the vorticity and ion pressure equations. I only compared the vorticity equation to S&C, so if there might be extra terms in other equations I will have missed them.Had to (?) change the way Laplace solve is done compared to Boussinesq case: subtract
Picontribution from right-hand-side before solving rather than subtractingPifrom the result afterward. Seems necessary because without Boussinesq approximation the coefficients ofphiandPiinside the divergence in the definition of vorticity are different (with/withoutNefactor), so can't solve directly forphi+Pi.Definitely needs checking: