Install helper binaries via Haskell (#256)

* Install helper binaries via Haskell script

* Fix variable naming bug in install.sh - DRY_RUN -> HVN_DRY_RUN

* Replace use of RecordWildCards with NamedFieldPuns to make the local bindings explicit

* Terminate script immediately when stack cannot be found

Author: jship

dependencies.cabal

@@ -110,6 +110,7 @@ do_setup() {
   local GENERATE_HOOGLE_DB=$3
   local DRY_RUN=$4
   local setup_path=${HVN_DEST}/scripts/setup.sh
+  local setup_haskell_path=${HVN_DEST}/scripts/setup_haskell.hs
 
   . $setup_path || { \
     err "Failed to source ${setup_path}."
@@ -122,7 +123,21 @@ do_setup() {
 
   if [ "$FULL_INSTALL" == true ]
   then
-    setup_haskell $HVN_DEST $GENERATE_HOOGLE_DB $DRY_RUN
+    local ARG_NO_HOOGLE_DB="--no-hoogle"
+    local ARG_NO_HELPER_BINS="--no-helper-bins"
+
+    if [ "$GENERATE_HOOGLE_DB" == true ]
+    then
+      ARG_NO_HOOGLE_DB=
+    fi
+
+    if [ "$DRY_RUN" == false ]
+    then
+      ARG_NO_HELPER_BINS=
+    fi
+
+    stack $setup_haskell_path $ARG_NO_HOOGLE_DB $ARG_NO_HELPER_BINS ; RETCODE=$?
+    [ ${RETCODE} -ne 0 ] && exit_err "setup_haskell.hs failed with error ${RETCODE}."
   fi
 
   setup_done $HVN_DEST
@@ -167,7 +182,7 @@ do
     --basic) shift; HVN_FULL_INSTALL=false; continue;;
     --repo) shift; HVN_REPO=$1; shift; continue;;
     --no-hoogle) shift; HVN_GENERATE_HOOGLE_DB=false; continue;;
-    --dry-run) shift; DRY_RUN=true; continue;;
+    --dry-run) shift; HVN_DRY_RUN=true; continue;;
     *) usage;;
   esac
 done

install.sh

@@ -17,114 +17,6 @@ stack_resolver() {
   return 0
 }
 
-setup_haskell() {
-  local HVN_DEST=$1
-  local GENERATE_HOOGLE_DB=$2
-  local DRY_RUN=$3
-  local RETCODE
-
-  if ! check_exist stack >/dev/null ; then
-    err "Installer requires Stack."
-    msg "Installation instructions: http://docs.haskellstack.org/en/stable/README/#how-to-install"
-    exit 1
-  fi
-
-  msg "Setting up GHC if needed..."
-  stack setup --verbosity warning ; RETCODE=$?
-  [ ${RETCODE} -ne 0 ] && exit_err "Stack setup failed with error ${RETCODE}."
-
-  if [ $(stack --verbosity 0 path --local-bin 2> /dev/null) ]
-  then
-    local STACK_BIN_PATH=$(fix_path $(stack --verbosity 0 path --local-bin))
-    local STACK_GLOBAL_DIR=$(fix_path $(stack --verbosity 0 path --stack-root))
-    local STACK_GLOBAL_CONFIG=$(fix_path $(stack --verbosity 0 path --config-location))
-  else
-    local STACK_BIN_PATH=$(fix_path $(stack --verbosity 0 path --local-bin-path))
-    local STACK_GLOBAL_DIR=$(fix_path $(stack --verbosity 0 path --global-stack-root))
-    local STACK_GLOBAL_CONFIG=$(fix_path $(stack --verbosity 0 path --config-location))
-  fi
-  local STACK_RESOLVER=$(stack_resolver $STACK_GLOBAL_CONFIG)
-
-  detail "Stack bin path: ${STACK_BIN_PATH}"
-  detail "Stack global path: ${STACK_GLOBAL_DIR}"
-  detail "Stack global config location: ${STACK_GLOBAL_CONFIG}"
-  detail "Stack resolver: ${STACK_RESOLVER}"
-
-  if [ -z ${STACK_BIN_PATH} ] || [ -z ${STACK_GLOBAL_DIR} ] || [ -z ${STACK_GLOBAL_CONFIG} ] ; then
-    exit_err_report "Incorrect stack paths."
-  fi
-
-  detail "${HVN_DEST}/.stack-bin -> ${STACK_BIN_PATH}"
-  ln -sf ${STACK_BIN_PATH} ${HVN_DEST}/.stack-bin
-
-  msg "Installing helper binaries..."
-  
-  # Install ghc-mod via active stack resolver for maximum out-of-the-box compatibility.
-  # Stack dependency solving requires cabal to be on the PATH.
-  stack --resolver ${STACK_RESOLVER} install ghc-mod cabal-install --verbosity warning ; RETCODE=$?
-  [ ${RETCODE} -ne 0 ] && exit_err "Installing ghc-mod/cabal-install failed with error ${RETCODE}."
-
-  # Install hindent via pinned LTS to ensure we have version 5.
-  if [ "$DRY_RUN" == false ]
-  then
-    stack --resolver lts-8.6 install hindent --install-ghc --verbosity warning ; RETCODE=$?
-  else
-    stack --resolver lts-8.6 install hindent --install-ghc --verbosity warning --dry-run ; RETCODE=$?
-  fi
-  [ ${RETCODE} -ne 0 ] && exit_err "Installing hindent failed with error ${RETCODE}."
-
-  # Create a temporary directory for helper binary dependency solving.
-  local HELPER_BINARIES_TEMP_DIR=$(mktemp -d)
-  cp ${HVN_DEST}/dependencies.cabal $HELPER_BINARIES_TEMP_DIR
-  pushd $HELPER_BINARIES_TEMP_DIR
-
-  # Solve the versions of all helper binaries listed in dependencies.cabal.
-  stack init --solver --install-ghc ; RETCODE=$?
-  [ ${RETCODE} -ne 0 ] && exit_err "Solving dependencies for helper binaries failed with error ${RETCODE}."
-
-  # Clean up the comments and blank lines from stack.yaml.
-  sed -i.bak1 -e 's/^#.*$//' -e '/^$/d' stack.yaml
-  
-  # Remove warning message from generated stack.yaml.
-  sed -i.bak2 -e '/user-message/,+3d' stack.yaml
-
-  # Install all solved dependency versions for the helper binaries, while skipping local dependencies package and GHC.
-  # Also skipping bogus 'invalid-cabal-flag-settings' dependency from base: https://github.com/commercialhaskell/stack/issues/2969
-  local HELPER_BINARIES_DEPENDENCY_LIST=$(stack list-dependencies --separator - | grep -vE "^dependencies-|^ghc-[0-9]\.[0-9]\.[0-9]$|^invalid-cabal-flag-settings-|^rts-")
-
-  for dep in $HELPER_BINARIES_DEPENDENCY_LIST
-  do
-    if [ "$DRY_RUN" == false ]
-    then
-      stack install $dep ; RETCODE=$?
-    else
-      stack install $dep --dry-run ; RETCODE=$?
-    fi
-    [ ${RETCODE} -ne 0 ] && exit_err "Installing helper binary dependency $dep failed with error ${RETCODE}."
-  done
-
-  # Clean up temporary directory.
-  popd
-  rm -rf $HELPER_BINARIES_TEMP_DIR
-
-  msg "Installing git-hscope..."
-  cp ${HVN_DEST}/git-hscope ${STACK_BIN_PATH}
-
-  if [ "$GENERATE_HOOGLE_DB" == true ]
-  then
-    msg "Building Hoogle database..."
-    ${STACK_BIN_PATH}/hoogle generate
-  fi
-
-  msg "Configuring codex to search in stack..."
-  cat > $HOME/.codex <<EOF
-hackagePath: $STACK_GLOBAL_DIR/indices/Hackage/
-tagsFileHeader: false
-tagsFileSorted: false
-tagsCmd: hasktags --extendedctag --ignore-close-implementation --ctags --tags-absolute --output='\$TAGS' '\$SOURCES'
-EOF
-}
-
 # Print package name to install if command is not found
 # $1: command name
 # $2: package name